Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conf: default to $EDITOR/$GEDITOR #3692

Merged
merged 2 commits into from
Jul 17, 2020
Merged

conf: default to $EDITOR/$GEDITOR #3692

merged 2 commits into from
Jul 17, 2020

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Jul 15, 2020 •
edited
Loading

From the platforms proposal document: https://cylc.github.io/cylc-admin/proposal-config-changes.html#editors

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required (docs auto-generated from the config).

@oliver-sanders oliver-sanders added this to the cylc-8.0a3 milestone Jul 15, 2020
@oliver-sanders oliver-sanders self-assigned this Jul 15, 2020
@oliver-sanders oliver-sanders force-pushed the geditor branch 2 times, most recently from 950141f to 80aa3e0 Compare July 15, 2020 17:09
datamel
datamel approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the tests and checked the code. Happy with this change. As an aside (which became apparent through running your new test @oliver-sanders), the test battery is picking up the flow.rc and not using flow-tests.rc, is this the plan to get rid of flow-tests.rc? Apologies if I have missed something documented about this already!

@datamel datamel merged commit 3d01171 into cylc:master Jul 17, 2020
@oliver-sanders
Copy link
Member Author

oliver-sanders commented Jul 17, 2020 •
edited
Loading

the test battery is picking up the flow.rc and not using flow-tests.rc, is this the plan to get rid of flow-tests.rc? Apologies if I have missed something documented about this already!

Damn! That needs to be fixed. There is no plan to retire the flow-tests.rc though it will get renamed inline with the configuration file changes.

Please raise a bug report and tag it against 8.0a3.

@oliver-sanders oliver-sanders deleted the geditor branch July 17, 2020 12:27
@dpmatthews dpmatthews mentioned this pull request Sep 18, 2020
Closed
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
@oliver-sanders oliver-sanders mentioned this pull request Apr 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamel datamel datamel approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
cylc-8.0b0
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @hjoliver @datamel